Skip to content

blueprint: installer kernel args (RHEL-107495)#1727

Merged
achilleas-k merged 1 commit into
osbuild:mainfrom
supakeen:installer-kernel
Aug 13, 2025
Merged

blueprint: installer kernel args (RHEL-107495)#1727
achilleas-k merged 1 commit into
osbuild:mainfrom
supakeen:installer-kernel

Conversation

@supakeen

@supakeen supakeen commented Aug 5, 2025

Copy link
Copy Markdown
Member

Allows for the customization of kernel arguments as used by installer environments. Anaconda takes certain actions based on the kernel arguments supplied such as configuring the installed system with them.

We've had the ability to customize these for disk images for a while now. We also need them for installers.

@supakeen supakeen requested a review from a team as a code owner August 5, 2025 11:24
@supakeen supakeen requested review from croissanne, mvo5 and thozza August 5, 2025 11:24
@supakeen supakeen marked this pull request as draft August 5, 2025 11:30
@supakeen supakeen marked this pull request as ready for review August 5, 2025 12:04
@supakeen supakeen requested a review from achilleas-k August 5, 2025 12:04
@supakeen

supakeen commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

I had a quick chat about this with @achilleas-k and since it's not that much work we felt like this should be supported. However, I'm not entirely sure if we 'just' want to use customizations.kernel.append here, or use the new customization I've introduced (customizations.installer.kernel.append).

@thozza thozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan still to have a separate Kernel args customization for the installer? IIRC, the outcome from the discussion last week was that Anaconda always sets the installer kernel args on the installed host, so it makes little sense to separate installer kernel args from the payload. Is that still the case?

@supakeen

Copy link
Copy Markdown
Member Author

Is the plan still to have a separate Kernel args customization for the installer? IIRC, the outcome from the discussion last week was that Anaconda always sets the installer kernel args on the installed host, so it makes little sense to separate installer kernel args from the payload. Is that still the case?

No, it makes sense; however when I created this PR this hadn't been discussed/there wasn't consensus yet :)

@supakeen supakeen marked this pull request as draft August 11, 2025 09:37
@supakeen supakeen force-pushed the installer-kernel branch 2 times, most recently from 0d4ec4b to a00773f Compare August 12, 2025 12:24
Append the `kernel.append` customization to installer images
images of the `image-installer` type.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
@supakeen supakeen marked this pull request as ready for review August 12, 2025 12:40
@supakeen

supakeen commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

Changed this to apply kernel arguments straight from kernel.append instead of a new blueprint, ready for review :)


I don't have time right now but we really need to take a good look at all of our ISO things, they've gotten messy; things are duplicated quite a bit and (slightly) different approaches are being used even within the same function.

@bcl bcl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thozza thozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k achilleas-k added this pull request to the merge queue Aug 13, 2025
Merged via the queue into osbuild:main with commit 263f33c Aug 13, 2025
23 checks passed
mvo5 added a commit to mvo5/images that referenced this pull request Aug 21, 2025
Support for kernel options in the iso got added to the tar installer
in osbuild#1727

We also want this for the container installer so do a similar
change here.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 25, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 25, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 25, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 26, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 27, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 28, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Aug 28, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 10, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 15, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 16, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 22, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 22, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Sep 29, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Oct 6, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
mvo5 added a commit to mvo5/images that referenced this pull request Oct 7, 2025
Support for kernel options in the iso got added to the tar
installer in osbuild#1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 7, 2025
Support for kernel options in the iso got added to the tar
installer in #1727.

For consistency this commit also enables it for the other
installers via the pre-existing `AdditionalKernelOpts`
that is part of the `manifest.InstallerCustomizations`.

A helper to read the kernel options from the customizations
and default image type(s) is extracted as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants